Host Software Table: Add vulnerability filters to API and UI #26995

RachelElysia · 2025-03-10T15:27:15Z

Issue

For #22445

Description

This feature will be merged before Non-vulnerable apps showing when filtering by "Vulnerable software" on host details page #26824
This feature is now only vuln filtering as we are removing the search filter query by CVE feature and creating a new ticket for it
- NOTE: Search filter query by CVE feature will be added after Host details page: software vulnerability severity filters #22445 and Non-vulnerable apps showing when filtering by "Vulnerable software" on host details page #26824 to layer on the code correctly to add all 3 features
Tests will be added with Non-vulnerable apps showing when filtering by "Vulnerable software" on host details page #26824 tests to avoid conflicts

Screenshots/screenrecordings

TODO

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes
A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
Manual QA for all new/changed functionality

…ftware

codecov · 2025-03-10T15:38:43Z

Codecov Report

Attention: Patch coverage is 19.73684% with 61 lines in your changes missing coverage. Please review.

Project coverage is 63.96%. Comparing base (129e9d5) to head (fd722f2).
Report is 111 commits behind head on main.

Files with missing lines	Patch %	Lines
...ages/hosts/details/cards/Software/HostSoftware.tsx	2.94%	33 Missing ⚠️
server/datastore/mysql/software.go	41.17%	15 Missing and 5 partials ⚠️
...s/Software/HostSoftwareTable/HostSoftwareTable.tsx	0.00%	6 Missing ⚠️
...ftwarePage/SoftwareTitles/SoftwareTable/helpers.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #26995      +/-   ##
==========================================
- Coverage   63.99%   63.96%   -0.03%     
==========================================
  Files        1695     1707      +12     
  Lines      161602   163021    +1419     
  Branches     4299     4384      +85     
==========================================
+ Hits       103412   104276     +864     
- Misses      50166    50612     +446     
- Partials     8024     8133     +109

Flag	Coverage Δ
backend	`64.74% <41.17%> (-0.02%)`	⬇️
frontend	`54.43% <2.38%> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

frontend/pages/hosts/details/cards/Software/HostSoftwareTable/HostSoftwareTable.tsx

RachelElysia · 2025-03-10T17:55:11Z

Heads up we are doing this order from @ksykulev in this slack thread:

What we're going to do >
Take out the software name and cve name match into a new issue
merge Rachel's PR
merge my PR (i'll do the merge conflict resolution)
work on the new issue that will add software name + cve name matching
That way the commit history makes sense. And during testing, we can test all 3 issues at once.

server/datastore/mysql/software.go

ksykulev · 2025-03-10T23:48:51Z

frontend/pages/hosts/details/cards/Software/_styles.scss

-              }
-            }
-            @media (max-width: $break-sm) {
+            @media (max-width: ($break-lg - 1)) {
              .status__cell {
                display: none;
                width: 0;


Nice! Looks good on a small screen as well:

ksykulev · 2025-03-10T23:48:57Z

server/datastore/mysql/software.go

+		return nil, nil, fleet.NewInvalidArgumentError(
+			"query", "min_cvss_score, max_cvss_score, and exploit can only be provided with vulnerable=true",
+		)
+	}


Do we care about any validations on MinimumCVSS is less than MaximumCVSS?

It'll just return no items right? I don't really care either way

Yup! It will just return 0 items. Was just curious how in depth or validations get. 👍
This is a non-blocking.

sgtm, yeah idk, I'm not familiar with BE patterns for invalid options

tl;dr doesn't seem like we are doing any sort of intelligent validations around those values. Let's not add it here then 👍

Looking at all the other places we use MinimumCVSS and MaximumCVSS
In the datastore layer:
https://github.com/fleetdm/fleet/blob/main/server/datastore/mysql/software.go#L1489
https://github.com/fleetdm/fleet/blob/main/server/datastore/mysql/software.go#L1146
https://github.com/fleetdm/fleet/blob/main/server/datastore/mysql/software_titles.go#L108
https://github.com/fleetdm/fleet/blob/main/server/datastore/mysql/software_titles.go#L364

In the service layer:
https://github.com/fleetdm/fleet/blob/main/ee/server/service/software.go#L13
https://github.com/fleetdm/fleet/blob/main/server/service/software_titles.go#L87
https://github.com/fleetdm/fleet/blob/main/server/service/software.go#L113
https://github.com/fleetdm/fleet/blob/main/server/service/software.go#L244

ksykulev

These look good to me 👍

iansltx

One code style thing, one legit question. Otherwise LGTM on the frontend side!

frontend/pages/hosts/details/cards/Software/HostSoftware.tsx

iansltx · 2025-03-12T05:43:50Z

frontend/pages/hosts/details/cards/Software/HostSoftware.tsx

+    const { available_for_install } = queryParams;
+    if (available_for_install) {
+      return "installableSoftware";
+    }
+    return "allSoftware";


Suggested change

const { available_for_install } = queryParams;

if (available_for_install) {

return "installableSoftware";

}

return "allSoftware";

return queryParams.available_for_install ? "installableSoftware" : "allSoftware";

Non-blocking, but the one-liner seems clear enough?

RachelElysia and others added 9 commits March 4, 2025 15:50

Fleet UI: Update to allow vuln filters on host softwarE

899a6ff

Start of backend

0b7c694

Work towards responsive header, still overflow on low widths

d23ce26

Software BE updates

9d64221

wip: filter out non-vulnerable software if we only want vulnerable so…

8a26ba0

…ftware

Revert late join

1620f27

FE Work towards improving types across multiple pages

35d2d28

Backend working, needs cleanup, needs fe filter cleanup

79c8b03

Fix usecallback, stray logs

823bac8

RachelElysia temporarily deployed to Docker Hub March 10, 2025 15:27 — with GitHub Actions Inactive

Fix styling, remove logs, part 1 done, no tests

bc905db

RachelElysia temporarily deployed to Docker Hub March 10, 2025 15:58 — with GitHub Actions Inactive

Add changelog

f58c0d2

RachelElysia temporarily deployed to Docker Hub March 10, 2025 17:41 — with GitHub Actions Inactive

RachelElysia commented Mar 10, 2025

View reviewed changes

frontend/pages/hosts/details/cards/Software/HostSoftwareTable/HostSoftwareTable.tsx Show resolved Hide resolved

RachelElysia marked this pull request as ready for review March 10, 2025 17:53

RachelElysia requested review from a team as code owners March 10, 2025 17:53

RachelElysia assigned iansltx Mar 10, 2025

ksykulev reviewed Mar 10, 2025

View reviewed changes

server/datastore/mysql/software.go Outdated Show resolved Hide resolved

iansltx assigned ksykulev and unassigned iansltx Mar 10, 2025

ksykulev reviewed Mar 10, 2025

View reviewed changes

Replace len check with hasCVEFilters boolean

096bfbc

RachelElysia temporarily deployed to Docker Hub March 11, 2025 19:40 — with GitHub Actions Inactive

RachelElysia requested a review from ksykulev March 11, 2025 19:40

RachelElysia assigned iansltx Mar 11, 2025

ksykulev previously approved these changes Mar 11, 2025

View reviewed changes

iansltx reviewed Mar 12, 2025

View reviewed changes

Add check for vuln filter change, clean code

fd722f2

RachelElysia dismissed ksykulev’s stale review via fd722f2 March 12, 2025 13:51

RachelElysia deployed to Docker Hub March 12, 2025 13:51 — with GitHub Actions Active

RachelElysia requested a review from iansltx March 12, 2025 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Host Software Table: Add vulnerability filters to API and UI #26995

Host Software Table: Add vulnerability filters to API and UI #26995

RachelElysia commented Mar 10, 2025 •

edited

Loading

codecov bot commented Mar 10, 2025 •

edited

Loading

RachelElysia commented Mar 10, 2025

ksykulev Mar 10, 2025

ksykulev Mar 10, 2025

RachelElysia Mar 11, 2025

ksykulev Mar 11, 2025

RachelElysia Mar 11, 2025

ksykulev Mar 11, 2025

ksykulev left a comment

iansltx left a comment

iansltx Mar 12, 2025

RachelElysia Mar 12, 2025

Host Software Table: Add vulnerability filters to API and UI #26995

Are you sure you want to change the base?

Host Software Table: Add vulnerability filters to API and UI #26995

Conversation

RachelElysia commented Mar 10, 2025 • edited Loading

Issue

Description

Screenshots/screenrecordings

Checklist for submitter

codecov bot commented Mar 10, 2025 • edited Loading

Codecov Report

RachelElysia commented Mar 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ksykulev left a comment

Choose a reason for hiding this comment

iansltx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RachelElysia commented Mar 10, 2025 •

edited

Loading

codecov bot commented Mar 10, 2025 •

edited

Loading