Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-3009: fix dead links #953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lipsyre
Copy link

@lipsyre lipsyre commented Mar 9, 2025

Hi! I noticed a couple of broken links while reading through the EIP docs:

  • In ERC-3009.md, there was a sneaky typo in the EIP-2612 implementation link — EI32612.sol instead of EIP2612.sol
  • In ERC-721.md, the path to OpenZeppelin’s SafeERC20.sol was outdated — their repo structure now has a /utils/ directory for helpers.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 9, 2025

File ERCS/erc-3009.md

Requires 1 more reviewers from @DavidLKnott, @kbrizzle, @petejkim
Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

File ERCS/erc-721.md

Requires 1 more reviewers from @fulldecent
Requires 2 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Update ERC: fix dead links Update ERC-3009: fix dead links Mar 9, 2025
Copy link

github-actions bot commented Mar 9, 2025

The commit b96b314 (as a parent of 46f80e2) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants