Aa 429 new aa capabilities erc #947
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🛑 |
bomanaps
reviewed
Mar 5, 2025
Comment on lines
+95
to
+96
| The purpose of this capability is allowing the applications to explicitly specify the time range during which | ||
| the requested operations will be valid after signing. |
There was a problem hiding this comment.
Suggested change
| The purpose of this capability is allowing the applications to explicitly specify the time range during which | |
| the requested operations will be valid after signing. | |
| The purpose of this capability is allowing the applications to explicitly specify the time range during which the requested operations will be valid after signing. |
Comment on lines
+113
to
+114
| The Wallet Application MUST verify the time range [`validAfter`..`validUntil`] is valid and present it to the | ||
| user in a human-readable way for confirmation as part of the transaction information. |
There was a problem hiding this comment.
Suggested change
| The Wallet Application MUST verify the time range [`validAfter`..`validUntil`] is valid and present it to the | |
| user in a human-readable way for confirmation as part of the transaction information. | |
| The Wallet Application MUST verify the time range [`validAfter`..`validUntil`] is valid and present it to the user in a human-readable way for confirmation as part of the transaction information. |
Comment on lines
+120
to
+121
| The purpose of this capability is allowing the applications to explicitly specify the components of the | ||
| multidimensional nonce as defined in [ERC-4337](./eip-4337.md). |
There was a problem hiding this comment.
Suggested change
| The purpose of this capability is allowing the applications to explicitly specify the components of the | |
| multidimensional nonce as defined in [ERC-4337](./eip-4337.md). | |
| The purpose of this capability is allowing the applications to explicitly specify the components of the multidimensional nonce as defined in [ERC-4337](./eip-4337.md). |
Comment on lines
+17
to
+18
| With EIP-5792, apps and wallets can communicate about any advanced features using "capabilities" - extensions | ||
| to the base protocol that must be defined in separate documents. |
There was a problem hiding this comment.
Suggested change
| With EIP-5792, apps and wallets can communicate about any advanced features using "capabilities" - extensions | |
| to the base protocol that must be defined in separate documents. | |
| With EIP-5792, apps and wallets can communicate about any advanced features using "capabilities" - extensions to the base protocol that must be defined in separate documents. |
Comment on lines
+31
to
+32
| It extends the [EIP-5792](./eip-5792) wallet capability model to encompass critical aspects of AA, | ||
| ensuring dApps can seamlessly adapt to different AA Wallets without requiring custom solutions. |
There was a problem hiding this comment.
Suggested change
| It extends the [EIP-5792](./eip-5792) wallet capability model to encompass critical aspects of AA, | |
| ensuring dApps can seamlessly adapt to different AA Wallets without requiring custom solutions. | |
| It extends the [EIP-5792](./eip-5792) wallet capability model to encompass critical aspects of AA, ensuring dApps can seamlessly adapt to different AA Wallets without requiring custom solutions. |
Comment on lines
+43
to
+44
| This capability is designed to use with [EIP-7702](./eip-7702) and requests the Wallet Application to provide | ||
| an EIP-7702 authorization tuple for the specified address as part of the AA transaction. |
There was a problem hiding this comment.
Suggested change
| This capability is designed to use with [EIP-7702](./eip-7702) and requests the Wallet Application to provide | |
| an EIP-7702 authorization tuple for the specified address as part of the AA transaction. | |
| This capability is designed to use with [EIP-7702](./eip-7702) and requests the Wallet Application to provide an EIP-7702 authorization tuple for the specified address as part of the AA transaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: