Download both the full and libs-only tarball in extended LLVM mode #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Espressif-provided LLVM toolchain no longer has the libs-only tarball as a strict subset of the full tarball. Instead the "full" tarball now contains a clang with libclang built in. To work around this we now need to get _both_ tarballs if we're in extended LLVM mode. Cf. espressif/llvm-project#99 Signed-off-by: Johannes Löthberg <[email protected]>
kyrias
force-pushed
the
fix-extended-llvm
branch
from
eb380a9 to
5c2e579
Compare
SergioGasquez
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
Tests
Before:
esp@b34942db9cf7:~/espup$ cargo r -r -- install -v 1.79.0.0 -e
...
[info]: Installation successfully completed!
...
esp@b34942db9cf7:~/espup$ ls /home/esp/.rustup/toolchains/esp/xtensa-esp32-elf-clang/esp-17.0.1_20240419/esp-clang/lib/
clang clang-runtimes libLTO.so libLTO.so.17
With this PR:
esp@bc86fe468d17:~/espup$ cargo r -r -- install -v 1.79.0.0 -e
....
[info]: Installation successfully completed!
...
esp@bc86fe468d17:~/espup$ ls /home/esp/.rustup/toolchains/esp/xtensa-esp32-elf-clang/esp-17.0.1_20240419/esp-clang/lib/
clang clang-runtimes libLLVM-17.0.1.so libLLVM-17.so libLLVM.so libLTO.so libLTO.so.17 libclang-cpp.so libclang-cpp.so.17 libclang.so libclang.so.17 libclang.so.17.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Espressif-provided LLVM toolchain no longer has the libs-only tarball as a strict subset of the full tarball. Instead the "full" tarball now contains a clang with libclang built in. To work around this we now need to get both tarballs if we're in extended LLVM mode.
Cf. espressif/llvm-project#99