Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using hardcoded Xtensa Rust version #38

Merged
merged 8 commits into from
Nov 3, 2022
Merged

Avoid using hardcoded Xtensa Rust version #38

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
143619f
build: ➕ Add serde-json
SergioGasquez Nov 3, 2022
275c0cc
feat: ✨ Add fn to get the latest Xtensa rust release version
SergioGasquez Nov 3, 2022
76c903b
feat: ⚡️ Avoid using a hardcoded Xtensa Rust version
SergioGasquez Nov 3, 2022
52da41d
refactor: ♻️ Move version functions to XtensaRust
SergioGasquez Nov 3, 2022
cec06ac
fix: 🐛 Fix retain condition
SergioGasquez Nov 3, 2022
7a5d30b
test: 🧪 Add parse_version tests
SergioGasquez Nov 3, 2022
eea93c6
fix: 🐛 Fix clippy warnings
SergioGasquez Nov 3, 2022
5fc3c4e
chore: 🎨 Update user agent
SergioGasquez Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: 🧪 Add parse_version tests
  • Loading branch information
@SergioGasquez
SergioGasquez committed Nov 3, 2022
commit 7a5d30bb20d541fb2bcb50d7f16be420a757c53b
16 changes: 16 additions & 0 deletions src/toolchain/rust.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,3 +308,19 @@ fn install_rust_nightly(version: &str) -> Result<()> {
.run()?;
Ok(())
}

#[cfg(test)]
mod tests {
use crate::toolchain::rust::XtensaRust;

#[test]
fn test_xtensa_rust_parse_version() {
assert_eq!(XtensaRust::parse_version("1.45.0.0").unwrap(), "1.45.0.0");
assert_eq!(XtensaRust::parse_version("1.45.0.1").unwrap(), "1.45.0.1");
assert_eq!(XtensaRust::parse_version("1.1.1.1").unwrap(), "1.1.1.1");
assert_eq!(XtensaRust::parse_version("a.1.1.1").is_err(), true);
assert_eq!(XtensaRust::parse_version("1.1.1.1.1").is_err(), true);
assert_eq!(XtensaRust::parse_version("1..1.1").is_err(), true);
assert_eq!(XtensaRust::parse_version("1._.*.1").is_err(), true);
}
}