Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complement.sh: don't use remote base synapse image #18210

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

complement.sh: don't use remote base synapse image #18210

wants to merge 7 commits into from

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Mar 4, 2025 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@AndrewFerr
complement.sh: don't use remote base synapse image
b68ceb7 
Ensure that the synapse-workers & complement-synapse images are built
from the local base synapse image that was just built, instead of from
the latest synapse image pulled from a public registry.
@AndrewFerr
Remove local tags for unpushed images
9e0490e 
as there is no risk of pulling these from a public registry
@AndrewFerr
Document how to use local images as base
215d94a
@AndrewFerr AndrewFerr requested a review from a team as a code owner March 4, 2025 15:42
AndrewFerr
AndrewFerr commented Mar 4, 2025
View reviewed changes
scripts-dev/complement.sh
SYNAPSE_TAG=matrixdotorg/synapse
$CONTAINER_RUNTIME build \
-t "$SYNAPSE_TAG" \
-t "$LOCAL_REGISTRY/$SYNAPSE_TAG" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, this could have added a custom tag to the image name (like :testing, instead of the implicit default of :latest), but using a dummy registry prevents accidentally pushing the built image to anywhere public.

@AndrewFerr
Refer to docker image "names", not "tags"
4c03b3b 
because the tag is really just the part of a name after the colon
@AndrewFerr
Show full name of built complement-synapse image
ee08a4a 
A tag of "latest" is included by default
@AndrewFerr
Document the SYNAPSE_VERSION build argument
6f7415c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndrewFerr