Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #2

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Update #2

merged 2 commits into from
Mar 21, 2023

Conversation

Jieiku
Copy link
Contributor

@Jieiku Jieiku commented Mar 19, 2023

I noticed your demo has been offline for a long time.

I fixed the theme files so that they can be hosted from a root domain or a subfolder, so for example:

https://elegaanz.github.io/
or
https://elegaanz.github.io/course/

previous because of the root path for the css and js file, this would never work from a subfolder, now it works either way.

I also pointed the demo to one I put up for now, you can merge it as is, or upload your own demo.

Hope this helps.

Copy link
Owner

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left a few comments, but it looks good otherwise.

@elegaanz elegaanz merged commit ad39ebc into elegaanz:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants