Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add jest types to test dir #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add jest types to test dir #128

wants to merge 1 commit into from

Conversation

erikian
Copy link
Member

@erikian erikian commented Feb 23, 2025

describe, expect and other global Jest types are marked as unresolved on my IDE because we're missing "types": ["jest"].

@erikian erikian requested a review from a team as a code owner February 23, 2025 12:20
dsanders11
dsanders11 reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these functions can be imported from @jest/globals which will better align with how it's done in Vitest, which this repo will be converted to after the Node 22 bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikian @dsanders11