Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): make entry point consistent between dev and prod #3871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

viliml
Copy link

@viliml viliml commented Mar 6, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
There's was no need to omit the index.html in development mode in the first place, and it makes relative URL resolve differently than in production.

@viliml viliml requested a review from a team as a code owner March 6, 2025 17:33
@erickzhao erickzhao changed the title fix: Make entry point path consistent between development and production fix(plugin-webpack): make entry point consistent between dev and prod Mar 6, 2025
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants