Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the signer signing an invalid certificate #466

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

riijj
Copy link

@riijj riijj commented Mar 16, 2022

The Signer will sign an invalid certificate when hostname is an IPV6 address

E.g :
Assuming the URL is https://[2606:4700:4700::1111]:443 , the CommonName of signed certificate will be: [2606 , the certificate is invalid.

this PR will fix the bug.

@elazarl
Copy link
Owner

elazarl commented Mar 16, 2022

Sounds good, isn't there something in the stdlib to do that?

@riijj
Copy link
Author

riijj commented Mar 17, 2022

Sounds good, isn't there something in the stdlib to do that?

Forgive me , I'm not sure what you mean

@elazarl
Copy link
Owner

elazarl commented Mar 17, 2022

@riijj a function to parse URL and take IPv6 into account

@elazarl elazarl merged commit f5c0d09 into elazarl:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants