Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'github.com/pkg/errors' with 'errors' #8259

Merged

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Feb 27, 2025

Description

This PR replaces usages of the archived package github.com/pkg/errors with errors and fmt packages.

Follows #8256

github.com/pkg/errors was not deleted from ATTRIBUTIONS.md because it is an indirect dependency for a few packages.

I used these commands to automate the refactoring process:

# Update `errors.Wrapf`:
find . -name "*.go" -exec sed -i '' -E 's/errors\.Wrapf\(([^,]+), "([^"]+)", ([^)]+)\)/fmt.Errorf\("\2: %w", \3, \1\)/g' {} +

# Update `errors.Wrap`:
find . -name "*.go" -exec sed -i '' -E 's/errors\.Wrap\(([^,]+), "([^"]+)"\)/fmt.Errorf\("\2: %w", \1\)/g' {} +

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@alexandear alexandear force-pushed the refactor/remove-pkg-errors branch from 5cdd0bb to e7e164b Compare February 27, 2025 13:26
@bryantbiggs bryantbiggs added skip-release-notes Causes PR not to show in release notes dependencies Pull requests that update a dependency file labels Feb 27, 2025
@alexandear alexandear force-pushed the refactor/remove-pkg-errors branch from e7e164b to 4031962 Compare February 27, 2025 13:51
Copy link
Member

@cheeseandcereal cheeseandcereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution

@cheeseandcereal cheeseandcereal merged commit 8fff9db into eksctl-io:main Feb 27, 2025
10 checks passed
@alexandear alexandear deleted the refactor/remove-pkg-errors branch February 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants