Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlx初步完成. #92

Merged
merged 21 commits into from
Sep 26, 2022
Merged

sqlx初步完成. #92

merged 21 commits into from
Sep 26, 2022

Conversation

archer-wyz
Copy link
Contributor

初步完成 sqlx的功能,还有如下工作留给明天:

  1. benchmark分析、优化
  2. 错误用例的测试

存在疑虑:
由于学习、工作阶段,sql的使用较少,加密也几乎没有使用过,对于使用场景不太熟悉;所以不太清楚 #53讨论中的key应该放在哪,目前修改了接口函数,key在加、解密时都要传入。当然,如果放在结构体里应用场景更广,只需搞一个装饰器即可。

加、解密的代码基本是复制、粘贴网络上的。

PS:
copier的代码,虽说已经做好了,但修改好后还是会提的。
eorm的issue,我需要去回顾一下sql。

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #92 (569b4e7) into dev (25b0743) will decrease coverage by 2.10%.
The diff coverage is 67.00%.

@@            Coverage Diff             @@
##              dev      #92      +/-   ##
==========================================
- Coverage   96.31%   94.21%   -2.11%     
==========================================
  Files          23       23              
  Lines         895     1140     +245     
==========================================
+ Hits          862     1074     +212     
- Misses         26       50      +24     
- Partials        7       16       +9     
Impacted Files Coverage Δ
sqlx/encrypt.go 67.64% <67.00%> (+67.64%) ⬆️
pool/task_pool.go 98.12% <0.00%> (-1.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你的测试可读性实在不高,还是按照我的建议来进行一点修改吧

@flycash
Copy link
Contributor

flycash commented Sep 23, 2022

最近忙翻了,不好意思……

Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.DS_Store 文件和根目录下的 encrypt_branchmark 文件都不用提交。
记得在 .CHANGELOG 文件里面加上这个 PR

@flycash
Copy link
Contributor

flycash commented Sep 26, 2022

image

算了,我先合并了这个,然后我在你的基础上修复这些问题。以后你要学会检查 license,以及添加 change log

@flycash flycash merged commit 8a60c9e into ecodeclub:dev Sep 26, 2022
flycash added a commit to flycash/ekit that referenced this pull request Sep 26, 2022
@flycash flycash linked an issue Sep 26, 2022 that may be closed by this pull request
flycash added a commit that referenced this pull request Sep 26, 2022
* sqlx: 修复 #92 中的代码风格问题

* ekit: 忽略掉任意的 .DS_Store 文件
longyue0521 pushed a commit to longyue0521/ekit that referenced this pull request Sep 26, 2022
* sqlx: 修复 ecodeclub#92 中的代码风格问题

* ekit: 忽略掉任意的 .DS_Store 文件
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlx: 加密列支持
2 participants