-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlx初步完成. #92
sqlx初步完成. #92
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #92 +/- ##
==========================================
- Coverage 96.31% 94.21% -2.11%
==========================================
Files 23 23
Lines 895 1140 +245
==========================================
+ Hits 862 1074 +212
- Misses 26 50 +24
- Partials 7 16 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你的测试可读性实在不高,还是按照我的建议来进行一点修改吧
最近忙翻了,不好意思…… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.DS_Store 文件和根目录下的 encrypt_branchmark 文件都不用提交。
记得在 .CHANGELOG 文件里面加上这个 PR
* sqlx: 修复 ecodeclub#92 中的代码风格问题 * ekit: 忽略掉任意的 .DS_Store 文件
初步完成 sqlx的功能,还有如下工作留给明天:
存在疑虑:
由于学习、工作阶段,sql的使用较少,加密也几乎没有使用过,对于使用场景不太熟悉;所以不太清楚 #53讨论中的key应该放在哪,目前修改了接口函数,key在加、解密时都要传入。当然,如果放在结构体里应用场景更广,只需搞一个装饰器即可。
加、解密的代码基本是复制、粘贴网络上的。
PS:
copier的代码,虽说已经做好了,但修改好后还是会提的。
eorm的issue,我需要去回顾一下sql。