Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkedList 实现 Get #31

Merged
merged 6 commits into from
Aug 17, 2022
Merged

LinkedList 实现 Get #31

merged 6 commits into from
Aug 17, 2022

Conversation

hhh111119
Copy link
Contributor

  • 实现 Get, 测试, benchmark
  • 简化 Add 函数

@hhh111119
LinkedList 实现 Get
4606a3b 
- 实现 Get, 测试, benchmark
- 简化 Add 函数
@hhh111119
添加 changelog
67ce90e
@codecov
Copy link

codecov bot commented Aug 15, 2022 •
edited
Loading

Codecov Report

Merging #31 (fe28679) into dev (f25bd16) will increase coverage by 21.69%.
The diff coverage is 96.38%.

❗ Current head fe28679 differs from pull request most recent head e3a1f04. Consider uploading reports for the commit e3a1f04 to get more accurate results

@@             Coverage Diff             @@
##              dev      #31       +/-   ##
===========================================
+ Coverage   61.06%   82.75%   +21.69%     
===========================================
  Files           6        6               
  Lines         113      203       +90     
===========================================
+ Hits           69      168       +99     
+ Misses         42       32       -10     
- Partials        2        3        +1
Impacted Files Coverage Δ
list/linked_list.go 77.14% <96.38%> (+77.14%) ⬆️
list/array_list.go 86.44% <0.00%> (+16.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

flycash
flycash requested changes Aug 16, 2022
View reviewed changes
@hhh111119
修改 getNode 函数
fe28679 
- 移除了 move 函数, 改为简单 if else
- 移除校验到公有函数判断
- 添加了更多测试
@hhh111119
移除冗余代码
e1f6ad1
@hhh111119 hhh111119 requested a review from flycash August 16, 2022 14:22
flycash
flycash reviewed Aug 17, 2022
View reviewed changes
flycash
flycash reviewed Aug 17, 2022
View reviewed changes
flycash
flycash reviewed Aug 17, 2022
View reviewed changes
@hhh111119
改动
e3a1f04 
- 修改 getNode
- 修改 测试代码 test case
@hhh111119
Copy link
Contributor Author

已修复

@hhh111119 hhh111119 requested a review from flycash August 17, 2022 15:53
@flycash flycash merged commit 08ad01a into ecodeclub:dev Aug 17, 2022
@hhh111119 hhh111119 deleted the LinkedList/Get branch August 18, 2022 02:40
flycash pushed a commit that referenced this pull request Sep 11, 2022
@hhh111119 @flycash
LinkedList 实现 Get (#31)
58496df 
* LinkedList 实现 Get
- 实现 Get, 测试, benchmark
- 简化 Add 函数
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flycash flycash Awaiting requested review from flycash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhh111119 @flycash