Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化slice的delete方法的性能 #203

Merged
merged 3 commits into from
Aug 8, 2023
Merged

优化slice的delete方法的性能 #203

merged 3 commits into from
Aug 8, 2023

Conversation

cancan927
Copy link
Contributor

No description provided.

@cancan927
Copy link
Contributor Author

这个需要更改changelog吗?感觉没什么必要啊

@flycash
Copy link
Contributor

flycash commented Aug 7, 2023

还是要改 changelog 的,因为要记录各个变更。你直接 Push 到你的分支上,这个合并请求就会更新的,不需要开新的合并请求。

@cancan927
Copy link
Contributor Author

这样可以了吗

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #203 (b423004) into dev (5e15d8a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #203      +/-   ##
==========================================
- Coverage   96.11%   96.11%   -0.01%     
==========================================
  Files          50       50              
  Lines        2577     2575       -2     
==========================================
- Hits         2477     2475       -2     
  Misses         79       79              
  Partials       21       21              
Files Changed Coverage Δ
internal/slice/delete.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@flycash flycash merged commit dd62bfc into ecodeclub:dev Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants