Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重构task pool相关测试用例 #178

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

longyue0521
Copy link
Collaborator

  1. 重构TestOnDemandBlockTaskPool_States,只关注是否能读取数据,读取的数据是否为零值,返回的chan是否被关闭等不再校验数据内容.
  2. 完善Taskpool有限状态机
  3. 添加t.Parallel() 尽可能利用Go测试框架的并发特性加速测试用例运行
  4. TestOnDemandBlockTaskPool_In_Closing_State/Shutdown

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #178 (eaae95c) into dev (155780c) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #178      +/-   ##
==========================================
- Coverage   96.14%   95.89%   -0.26%     
==========================================
  Files          43       43              
  Lines        2362     2362              
==========================================
- Hits         2271     2265       -6     
- Misses         73       77       +4     
- Partials       18       20       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@longyue0521 longyue0521 requested a review from flycash April 17, 2023 05:48
@longyue0521
Copy link
Collaborator Author

@flycash 有空看一下

@flycash flycash merged commit 63b5735 into ecodeclub:dev Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants