hashmap delete功能实现 #138
Merged
hashmap delete功能实现 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ming Deng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #138 +/- ##
==========================================
- Coverage 95.54% 95.48% -0.06%
==========================================
Files 36 36
Lines 1772 1818 +46
==========================================
+ Hits 1693 1736 +43
- Misses 62 64 +2
- Partials 17 18 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flycash
requested changes
Jan 4, 2023
mapx/hashmap.go
Outdated
| return root.value, true | ||
| } | ||
| pre.next = root.next | ||
| return root.value, true |
mapx/hashmap_test.go
Outdated
Comment on lines
164
to
166
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
这里改成 require.NoError(t, err)，我记得这里别的测试用例也用了这种写法，都改成 require.NoError()
mapx/hashmap_test.go
Outdated
| deleteKey testData | ||
| wantVal any | ||
| wantHashMap func() map[uint64]*node[testData, int] | ||
| IsFound bool |
mapx/hashmap_test.go
Outdated
| }, | ||
| IsFound: true, | ||
| }, | ||
| { |
There was a problem hiding this comment.
加一个测试用例，就是测试 hash code 冲突，然后是删除队首元素的。
mapx/hashmap_test.go
Outdated
| @@ -128,6 +128,140 @@ func TestHashMap(t *testing.T) { | |||
| } | |||
|
|
|||
| } | |||
| func TestHashMap_Delete(t *testing.T) { | |||
| testKV := []struct { | |||
There was a problem hiding this comment.
我其实不太建议这里提前准备好所有的数据，我建议每个测试用例单独准备测试数据。这个和 Get 不一样，Get 是纯粹的查询，不会修改数据，因此相互之间没有影响。而这个删除操作，测试用例之间是有影响的，比如说你必须要在每一个 testcase 里面小心，确保前面的测试用例没有把你当前测试用例的数据删除掉。
这违背了我们设计单元测试保持每一个测试用例独立性的要求
flycash
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.