feat: add support to_json() in DuckDB
#330
Draft
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keen85
commented
Mar 9, 2025
| @@ -2360,7 +2360,7 @@ def from_json( | |||
| return Column.invoke_anonymous_function(col, "FROM_JSON", schema) | |||
|
|
|||
|
|
|||
| @meta(unsupported_engines=["bigquery", "duckdb", "postgres", "snowflake"]) | |||
| @meta(unsupported_engines=["bigquery", "postgres", "snowflake"]) | |||
| def to_json(col: ColumnOrName, options: t.Optional[t.Dict[str, str]] = None) -> Column: | |||
| if options is not None: | |||
There was a problem hiding this comment.
I just noticed that DuckDB's behavior is a little bit different to PySpark's when applied to a STRUCT column:
DuckDB inludes all struct fields no matter what; PySpark omits fields containing NULL values.
So DuckDB's to_json(col) is equivalent to PySpark's to_json(col, options={"ignoreNullFields": False})
@eakmanrq, should we raise an error if options.get("ignoreNullFields", True) is not False; should we warn the users that options are not supported in DuckDB except ignoreNullFields=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for DuckDB's
to_json()function; compatible to PySparks'sto_json()