Added FlushAsync function which is called from CommitAsync with await keyword
#1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rwrite it instead. tolerate kafka message duplicate headers
… inside transaction
yang-xiaodong
requested changes
Dec 31, 2024
| @@ -68,6 +68,29 @@ protected virtual void Flush() | |||
| } | |||
| } | |||
|
|
|||
| protected virtual async Task FlushAsync() | |||
There was a problem hiding this comment.
Why not have Flush() call FlushAsync()?
| { | ||
| while (!_bufferList.IsEmpty) | ||
| { | ||
| #pragma warning disable CA2012 // Use ValueTasks correctly |
There was a problem hiding this comment.
Remove the #pragma warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added
FlushAsyncfunction which is called fromCommitAsyncwith await keyword to ensure that multiple messages are produced in correct order from a single transactionIssue(s) addressed:
How to test:
Produce multiple messages inside a single transaction and check the order
Checklist: