-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the Label not sized correctly on Android #28215
base: main
Are you sure you want to change the base?
Conversation
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
{ | ||
App.WaitForElement("EndButton"); | ||
App.Tap("EndButton"); | ||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshots on Mac and Windows. Running a build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshots were added for Windows
, but the Mac
image was not generated due to the build being canceled. @jsuarezruiz
Root Cause of the issue
TextView
. This can cause the TextView to occupymore width
than necessary.Description of Change
widthMeasureSpec
using the maximum line width from the Layout to improve text measurementaccuracy
and prevent unnecessary space usage.Issues Fixed
Fixes #27614
Tested the behaviour in the following platforms
Screenshot
LabelIssue.mov
LabelFix.mov