Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net10.0] [dotnet] Detect if the 'marshal-ilgen' component is needed. #22254

Draft
wants to merge 1 commit into
base: net10.0
Choose a base branch
from

Conversation

rolfbjarne
Copy link
Member

🚧 No need to review yet 🚧

Use the runtime's MarshalingPInvokeScanner task to detect if the
'marshal-ilgen' Mono component is required or not at runtime, and if we find
it's not required, remove it from the list of components we include in the
app.

PENDING:

Fixes #15684.

🚧 No need to review yet 🚧

Use the runtime's MarshalingPInvokeScanner task to detect if the
'marshal-ilgen' Mono component is required or not at runtime, and if we find
it's not required, remove it from the list of components we include in the
app.

PENDING:

* Doesn't work yet, due to numerous bugs in the MarshalingPInvokeScanner task. See #15684 for more info.
* App size numbers.
* Tests?
* Make sure it works from Windows.

Fixes #15684.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c4b59c5] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c4b59c50f9d981403fd8c77293241445c0af1ecd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build #c4b59c5] Build failed (Build macOS tests) 🔥

Build failed for the job 'Build macOS tests' (with job status 'Failed')

Pipeline on Agent
Hash: c4b59c50f9d981403fd8c77293241445c0af1ecd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c4b59c5] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c4b59c50f9d981403fd8c77293241445c0af1ecd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Error: 'make' failed for the hash 12d38e2.

Pipeline on Agent
Hash: c4b59c50f9d981403fd8c77293241445c0af1ecd [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #c4b59c5] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 113 tests passed.

Failures

❌ monotouch tests (macOS)

1 tests failed, 8 tests passed.
  • monotouch-test/macOS/Release (managed static registrar): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c4b59c50f9d981403fd8c77293241445c0af1ecd [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants