API diff between .NET 10 Preview1 and .NET 10 Preview2 #9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
rbhanda,
leecow and
victorisr
as code owners
release-notes/10.0/preview/preview2/api-diff/Microsoft.WindowsDesktop.App/10.0-preview2.md
Outdated
Show resolved
Hide resolved
.../preview2/api-diff/Microsoft.WindowsDesktop.App/10.0-preview2_System.Windows.Forms.Design.md
Outdated
Show resolved
Hide resolved
| + protected virtual System.Type? GetType(ComponentModel.Design.IDesignerHost? host, Reflection.AssemblyName? assemblyName, System.String typeName, System.Boolean? reference) { throw null; } | ||
| } | ||
| } | ||
| namespace System.Windows.Forms.Design |
There was a problem hiding this comment.
I think we had added some classes to this namespace, I need to double check that.
There was a problem hiding this comment.
Sounds good. Let me know.
…lso removed private dummy fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo area owners:
Libraries area owners:
New tool to generate diffs!
I have an open PR with the new tool we'll be using from now on to generate these API diffs: dotnet/sdk#46425
If you see any bugs, or if you don't see any APIs that should've showed up, please let me know.
Main differences with the old tool:
throw null. Void returning methods show{}instead of just the;.addandremoveaccessors.Bugs (currently working on them):
EditorBrowsableshould've been ignored, but sometimes they show up.private int _dummyPrimitiveis showing up in many places.System.prefix in API fullnames is unexpectedly getting removed in some cases, showing the diff as having an API added.