Add support fetch=EAGER OneToOne and ManyToOne for inheritance #11855
Conversation
|
if this approach is OK for you I'll add functional tests for this |
| if ($eagerEntity->inheritanceType !== ClassMetadata::INHERITANCE_TYPE_NONE) { | ||
| continue; // now this is why you shouldn't use inheritance | ||
| if ($eagerEntity->rootEntityName === $eagerEntity->name || $assoc['isOwningSide']) { |
There was a problem hiding this comment.
This is not enough to check if its only the root entity, it could be part of a deeper hierachy where from Root Entity A, the current entity B still has subclasses C and D.
There was a problem hiding this comment.
good point, fixed + added tests
There was a problem hiding this comment.
Hey @beberlei what do you think about this improvement? it's affected only inheritance with single table, mapped by final class and OneToOne or ManyToOne relation, let me know if you prefer to see additional tests or something else
Ps, I really want these improvement, because inheritance is a powerful feature, but when I try to display grid with 100 items I have additional 100 queries..
zavodnoyapl1992
force-pushed
the
support-eager-and-inheritance
branch
from
4a6b342 to
0abc438
Compare
Resolve N+1 problem when declare fetch="EAGER" and use inheritance in ManyToOne and OneToOne relations
resolve #11599