makePrimaryKey in docs #11848
Open
makePrimaryKey in docs #11848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge 2.18.x up into 3.0.x
* [Documentation] Adding link to Postgres upgrade article * Update UPGRADE.md * Update UPGRADE.md
…y-depr Remove unused trait
Merge 2.18.x up into 3.0.x
$listenerCallback is supposed to be a method name, so it is safe to require it is not a falsy string.
It is supposed to hold the name of a PHP property, and those cannot be falsy strings.
Account for inversedBy being a non-falsy-string or null
…ener Improve static analysis on AttachEntityListenersListener
…trine#11243) * Remove wrong asserts in DATE_ADD and DATE_SUB query AST function handlers * Require DBAL 3.8.2
* 2.18.x: Fix Static Analysis folder reference (doctrine#11281) docs: recommend safer way to disable logging (doctrine#11269) Remove unused baseline entries Treat '0' as a legitimate trim char
* 2.19.x: Fix Static Analysis folder reference (doctrine#11281) docs: recommend safer way to disable logging (doctrine#11269) Remove unused baseline entries Treat '0' as a legitimate trim char Add type field mapper documentation to the sidebar Mark document as orphan Use correction sectionauthor syntax Make docs valid according to guides 0.3.3 (doctrine#11252)
* 3.0.x: Remove broken assertion from DateAddFunction and DateSubFunction (doctrine#11243) Remove unused trait [Documentation] Adding link to Postgres upgrade article (doctrine#11257) fix: support array-type arg in QB variadic calls (doctrine#11242)
Lock files are supposed to contain uniqid()-generated values, so they cannot be falsy strings, but if they did, this would fix a bug.
This fixes a bug for files last modified on 1970-01-01 00:00:00, so… not worth backporting IMO.
If $lock->value was an empty string, this would fix a bug, but it never is, it is a uniqid-generated string.
The comment above mentions that on some platforms, it might return false, and this is why there is a check in the first place. Let us do exactly what is mentioned in the comment.
Remove implicit casts in FileLock.php
Allow (Array)ParameterType in QueryBuilder
* 2.18.x: Backport QueryParameterTest (doctrine#11288)
* 2.19.x: Backport QueryParameterTest (doctrine#11288)
* 3.0.x: Test different ways of settings query parameters Be less restrictive in DiscriminatorColumnMapping phpdoc (doctrine#11226) Allow (Array)ParameterType in QueryBuilder
Merge 2.20.x up into 3.3.x
This change was accidentally dropped during a merge up.
Run SA checks with PHP 8.4
Merge 2.20.x up into 3.3.x
UPGRADE: Document QueryBuilder::setParameters() Type enforcement
This will give a signal that there is work to be done without blocking other contributions by failing the build.
Display Doctrine deprecations when running PHPUnit
We should be using quoteSingleIdentifier(), assuming we only ever pass single identifiers here. See doctrine/dbal#6590
Address quoteIdentifier() deprecation
[DDC-551] fix, add filter support in oneToOne relation 2.20.x
…ctor This fixes a bug that arises when using Pagination and an entity relation is mapped with fetch-mode EAGER but setFetchMode LAZY (or anything that is not EAGER) has been used on the query. If the query use WITH condition, an exception is incorrectly raised (Associations with fetch-mode=EAGER may not be using WITH conditions). The class LimitSubqueryOutputWalker clones the query, but not its parameters and hints, so the generated subquery does not know that fetch-mode has been overridden. Fixes doctrine#11741
Clone query hints and parameters in `LimitSubqueryOutputWalker` constructor
Fix DQL example with composite key
This exception was dropped by mistake during a merge-up, and should be present until Doctrine officially supports property hooks.
Restore logic exception
Merge 2.20.x up into 3.3.x
I don't think isPrimaryKey even exists.
greg0ire
previously approved these changes
Feb 26, 2025
|
According to #11208, you should probably target 2.20.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think isPrimaryKey even exists.