Use exception in OCI8 driver, instead of relying on assert

[segrax]

Fixes a bug where disabled asserts in production left oci_parse() errors unchecked. Now uses explicit checks and exceptions

Fixes #6595

Q	A
Type	bug
Fixed issues	#6595

Summary

Fixes a bug where disabled asserts in production left oci_parse()
errors unchecked. Now uses explicit checks and exceptions

[derrabus]

Thank you. Can we cover this change with a test?

[segrax]

Thank you. Can we cover this change with a test?

yeah, test has just been added

[segrax]

@derrabus should be all good, the last failing test seems to be unrelated (and has happened a couple of times now)

Failures
 - sqlite (exited 1) - sqlite not installed. An error occurred during installation:
 The remote server returned an error: (503) Server Unavailable. Service Unavailable: Back-end server is at capacity
Sorry, we tried running command for 3 times and all attempts were unsuccessful!

Get-ChildItem : Cannot find path 'C:\tools\php' because it does not exist.
At line:6 char:3
+   Get-ChildItem -Path c:\tools\php
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\tools\php:String) [Get-ChildItem], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand
 
cd : Cannot find path 'C:\tools\php' because it does not exist

[morozov]

The AppVeyor build failure is tracked in #6601.

[segrax]

hey @derrabus and @morozov,
Is there anything else needed here?

[morozov]

Logic wise, looks good. Just nits.

[segrax]

@morozov its not clear why the last test failed, seems something in the setup of php extensions failed, but theres no log of it

/usr/bin/bash /home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/run.sh

==> Setup PHP
✓ PHP Installed PHP 8.3.13

==> Setup Extensions
Error: The process '/usr/bin/bash' failed with exit code 1

A test has been added.

[morozov]

@greg0ire here's another anomaly where the the modified code is reported as not covered. If you have a minute, could you analyze the coverage reports? I will run the test locally before merging.

[morozov]

@segrax it's an intermittent setup failure which sometimes happen in our CI environment. I've restarted the build. Once we figure out what's wrong with test coverage, we will merge the PR. Thank you.

[greg0ire]

I'm on my phone but from what I can see, only the appveyor files were processed. I'll reopen the codecov issue

[morozov]

Thanks, @segrax.