Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move samples into samples folder #97

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Move samples into samples folder #97

merged 1 commit into from
Feb 28, 2022

Conversation

gtardif
Copy link
Contributor

@gtardif gtardif commented Feb 28, 2022

Signed-off-by: Guillaume Tardif [email protected]

  • Moved samples from root to samples folder
  • Fix sample using docker CLI to run docker info rather than docker system df that leads into issues with command already in progress in the engine
  • Removed telepresence sample, too specific
  • updated CI to reflect new samples/ folder

@gtardif
Move samples into samples folder
c6653ec 
Signed-off-by: Guillaume Tardif <[email protected]>
@gtardif gtardif requested a review from mark-dr February 28, 2022 08:36
mark-dr
mark-dr approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@mark-dr mark-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gtardif gtardif merged commit 14e2845 into docker:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-dr mark-dr mark-dr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtardif @mark-dr