-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUI Theme #79
MUI Theme #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also added the guidelines to the Readme page. (I probably should have created a new branch for this. Apologies) |
docs/design/design-overview.md
Outdated
@@ -1,8 +1,9 @@ | |||
# UI Guidelines | |||
|
|||
We are currently in the process of developing our design system. But in the mean time, here are some UI guidelines that we highly recommend you use for your extension in order to create a seamless experience for Docker Desktop users. | |||
We are currently in the process of developing our design system. But in the mean time, here are some UI guidelines and a Material UI Theme that we highly recommend you use for your extension in order to create a seamless experience for Docker Desktop users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could expand this a bit. E.g.
Docker Desktop's UI is written in React and Material-UI, and we strongly recommend adopting this combination in your extensions as well. This brings the benefit of using our Material-UI Theme to easily replicate Docker Desktop's look & feel, and we'll continue to release libraries and utilities targeting this combination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark. Updated
Co-authored-by: Mark H <[email protected]>
Co-authored-by: Mark H <[email protected]>
added link to MUI theme