Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI Theme #79

Merged
merged 7 commits into from
Feb 3, 2022
Merged

MUI Theme #79

merged 7 commits into from
Feb 3, 2022

Conversation

mel-manohar
Copy link
Contributor

added link to MUI theme

added link to MUI theme
Copy link
Contributor

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mel-manohar
Copy link
Contributor Author

Also added the guidelines to the Readme page. (I probably should have created a new branch for this. Apologies)

@mel-manohar mel-manohar requested a review from gtardif February 2, 2022 09:44
@@ -1,8 +1,9 @@
# UI Guidelines

We are currently in the process of developing our design system. But in the mean time, here are some UI guidelines that we highly recommend you use for your extension in order to create a seamless experience for Docker Desktop users.
We are currently in the process of developing our design system. But in the mean time, here are some UI guidelines and a Material UI Theme that we highly recommend you use for your extension in order to create a seamless experience for Docker Desktop users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could expand this a bit. E.g.

Docker Desktop's UI is written in React and Material-UI, and we strongly recommend adopting this combination in your extensions as well. This brings the benefit of using our Material-UI Theme to easily replicate Docker Desktop's look & feel, and we'll continue to release libraries and utilities targeting this combination.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark. Updated

@gtardif gtardif merged commit df369d6 into main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants