Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension sample and tutorial about UI invoking docker commands #60

Merged
merged 2 commits into from
Dec 23, 2021
Merged

Extension sample and tutorial about UI invoking docker commands #60

merged 2 commits into from
Dec 23, 2021

Conversation

gtardif
Copy link
Contributor

@gtardif gtardif commented Dec 22, 2021

No description provided.

@gtardif gtardif changed the title Api docker cli sample Extension sample and tutorial about UI invoking docker commands Dec 22, 2021
Copy link
Contributor

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes


To preview the extension in Docker Desktop, close and open the Docker Desktop Dashboard once the installation has completed.

On the left-menu, you should see a new tab with the name `Disk usage`. Click on it to load the main window that will run the javascript code, invoke the `docekr system df` command and render the results.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On the left-menu, you should see a new tab with the name `Disk usage`. Click on it to load the main window that will run the javascript code, invoke the `docekr system df` command and render the results.
On the left menu, you should see a new tab with the name `Disk usage`. Click on it to load the main window that will run the javascript code, invoke the `docker system df` command, and render the results.

Copy link
Contributor

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gtardif gtardif merged commit 0995801 into docker:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants