Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #132

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Fix typos #132

merged 3 commits into from
Apr 14, 2022

Conversation

benja-M-1
Copy link
Member

@benja-M-1 benja-M-1 commented Apr 13, 2022

I tried to fix as many typos as I can.

This PR closes #131

@@ -57,7 +57,7 @@ ___

▸ **parseJsonObject**(): `any`

Parse a well formed JSON output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files under /api/reference are generated automatically from the docs in the pinata repo.

Did you change the comments in the pinata repo and then generated these files? Otherwise we'll lose this change the next time we regenerate the docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I'll do a pass on the pinata repo then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just take into account that files under /api/reference are generated automatically and we should avoid changing them manually.

Copy link
Contributor

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

Copy link
Contributor

@mark-dr mark-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work! I added a few suggested tweaks.

benja-M-1 and others added 3 commits April 14, 2022 10:03
Update docs/design/design-overview.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/backend.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/backend.md

Co-authored-by: Mark H <[email protected]>

Update docs/design/design-overview.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/backend.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/backend.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/dashboard.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/reference/interfaces/DockerDesktopClient.md

Co-authored-by: Mark H <[email protected]>

Update docs/dev/api/reference/interfaces/DockerDesktopClient.md

Co-authored-by: Mark H <[email protected]>

Update docs/index.md

Co-authored-by: Mark H <[email protected]>

Update docs/tutorials/minimal-backend-extension.md

Co-authored-by: Mark H <[email protected]>

Update docs/tutorials/minimal-frontend-extension.md

Co-authored-by: Mark H <[email protected]>

Update docs/tutorials/react-extension.md

Co-authored-by: Mark H <[email protected]>

Update samples/volumes-share/server/README.md

Co-authored-by: Mark H <[email protected]>

Update
Co-authored-by: Mark Higson <[email protected]>
Co-authored-by: Benjamin Grandfond <[email protected]>
Co-authored-by: Mark H <[email protected]>
@gtardif gtardif merged commit 8ccd4a0 into docker:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in DISTRIBUTION.md
4 participants