-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #132
Fix typos #132
Conversation
@@ -57,7 +57,7 @@ ___ | |||
|
|||
▸ **parseJsonObject**(): `any` | |||
|
|||
Parse a well formed JSON output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files under /api/reference are generated automatically from the docs in the pinata repo.
Did you change the comments in the pinata repo and then generated these files? Otherwise we'll lose this change the next time we regenerate the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I'll do a pass on the pinata repo then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just take into account that files under /api/reference
are generated automatically and we should avoid changing them manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this work! I added a few suggested tweaks.
225aeb7
to
0e210b9
Compare
Update docs/design/design-overview.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/backend.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/backend.md Co-authored-by: Mark H <[email protected]> Update docs/design/design-overview.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/backend.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/backend.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/dashboard.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/reference/interfaces/DockerDesktopClient.md Co-authored-by: Mark H <[email protected]> Update docs/dev/api/reference/interfaces/DockerDesktopClient.md Co-authored-by: Mark H <[email protected]> Update docs/index.md Co-authored-by: Mark H <[email protected]> Update docs/tutorials/minimal-backend-extension.md Co-authored-by: Mark H <[email protected]> Update docs/tutorials/minimal-frontend-extension.md Co-authored-by: Mark H <[email protected]> Update docs/tutorials/react-extension.md Co-authored-by: Mark H <[email protected]> Update samples/volumes-share/server/README.md Co-authored-by: Mark H <[email protected]> Update
Co-authored-by: Mark Higson <[email protected]> Co-authored-by: Benjamin Grandfond <[email protected]>
Co-authored-by: Mark H <[email protected]>
I tried to fix as many typos as I can.
This PR closes #131