Remove obsolete fields from metadata.json #116
Conversation
Signed-off-by: Guillaume Tardif <[email protected]>
| @@ -16,9 +16,6 @@ The metadata.json file must follow the format : | |||
|
|
|||
| ```json | |||
| { | |||
| "name": "volumes-share", | |||
| "provider": "Docker Inc.", | |||
| "icon": "extension-icon.svg", | |||
There was a problem hiding this comment.
seems to me the icon is needed still, or else, the extension uses a default icon. I kinda expecting the com.docker.desktop.extension.icon docker label would be used instead, but apparently not.
There was a problem hiding this comment.
Ah, thx for noticing! Indeed the name and provider metadata are provided with the image label. Icon appearing in the Marketplace is also provided with an image label (for extensions in the marketplace), but icon displayed in the left-hand-side drawer are available offline and are still extracted from the extension image itself.
Signed-off-by: Guillaume Tardif <[email protected]>
| @@ -65,7 +65,8 @@ FROM alpine:3.15 | |||
| LABEL org.opencontainers.image.title="HelloBackend" \ | |||
| org.opencontainers.image.description="A sample extension that runs a shell script inside a container's Desktop VM." \ | |||
| org.opencontainers.image.vendor="Docker Inc." \ | |||
| com.docker.desktop.extension.api.version="1.0.0-beta.1" | |||
| com.docker.desktop.extension.api.version="1.0.0-beta.1" \ | |||
| com.docker.desktop.extension.icon="https://www.docker.com/sites/default/files/d8/2019-07/Moby-logo.png" | |||
There was a problem hiding this comment.
@gtardif 404 Not Found?
There was a problem hiding this comment.
Ah thx to notice this. Updated to link from our media-resources.
Signed-off-by: Guillaume Tardif <[email protected]>
No description provided.