Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front end tutorial fixes. #105

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Front end tutorial fixes. #105

merged 3 commits into from
Mar 15, 2022

Conversation

Shy
Copy link
Contributor

@Shy Shy commented Mar 15, 2022

  • I renamed the extension to account for a use case where a user doesn't finish a tutorial and ends up conflicting when they install a different extension. We should make all the titles in the tutorials unique.
  • Fixed using extension code from the desktop-hello-backend-extension in the frontend tutorial.
  • Added a use case to showcase the update command. Just adding dark mode.

gtardif
gtardif approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thx!

@gtardif
Copy link
Contributor

gtardif commented Mar 15, 2022

@Shy trying to run the docs from your PR, I see there's still one outdated screenshot above the darkmode screenshot you added. Could you update this one as well (in images/ui-minimal-extension.png)?
Thx for taking the time to submit the PR, this is great help

@Shy
Copy link
Contributor Author

Shy commented Mar 15, 2022 •
edited
Loading

@gtardif Pushed. Let me know if they're too big. Took the screenshot on the retina macbook screen so they're pretty large.

@gtardif
Copy link
Contributor

gtardif commented Mar 15, 2022

Thx, looks good

@gtardif gtardif merged commit 034b503 into docker:main Mar 15, 2022
@Shy Shy deleted the frontend-tutorial-fixs branch March 15, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtardif gtardif gtardif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shy @gtardif