Stop recording the ecosystem param
#7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
L: go:modules
jeffwidman
commented
Jun 27, 2023
| package_managers: { | ||
| "channel" => channel | ||
| "cargo" => channel |
There was a problem hiding this comment.
I consciously renamed this from "channel" to "cargo" because that seemed more consistent with the pattern in other ecosystems.
In the long term, it probably won't matter because the entire shape of the data is changing, but in the short term it just seemed more straightforward this way.
jeffwidman
force-pushed
the
stop-recording-ecosystem-param
branch
2 times, most recently
from
5f525fe to
0185612
Compare
I'm starting a broader project to re-think how we instrument the ecosystem (language * package manager) versions. As part of this, the shape of the data that is sent to the internal API is changing, and the `ecosystem` param is no longer a separate k/v param. Although the cloud version of the API no longer uses/requires this param, customers running GHES could upgrade their version of `dependabot-core` but against an older version of the API which still requires/uses this param. So I continued to send the param, but as a placeholder string of `"deprecated"`, so that nothing breaks. Again, this param is no longer used by the cloud's version of the API, so it will never see the `ecosystem` placeholder value.
jeffwidman
force-pushed
the
stop-recording-ecosystem-param
branch
from
0185612 to
0187e67
Compare
|
This is ready for review. Smoke test failures are expected, TBH it might be simplest to fix them after merging the related PR's so that I don't have to keep re-doing them in lockstep. But keeping the PR's here in |
This was referenced Jul 4, 2023
brrygrdn
approved these changes
Jul 4, 2023
jeffwidman
added a commit
to dependabot/cli
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the `PackageManager` field is replaced by the `EcosystemVersions` field. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
added a commit
to dependabot/cli
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
added a commit
to dependabot/cli
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
jeffwidman
added a commit
to dependabot/cli
that referenced
this pull request
Jul 11, 2023
I confused myself in the previous two PR's... the `Ecosystem` field is actually removed, and the top-level `PackageManager` field is replaced by the `EcosystemVersions` field. As explained in #146, there may be an inner `PackageManager` field, which is optional. But no need to map it out in the struct, at least not yet. For background context: * #145 * #146 * dependabot/dependabot-core#7492 * dependabot/dependabot-core#7517 Caught this discrepancy over here: * https://github.com/dependabot/smoke-tests/pull/98/files#r1260099204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting a broader project to re-think how we instrument the ecosystem (language * package manager) versions.
As part of this, the shape of the data that is sent to the internal API is changing, and the
ecosystemparam is no longer a separate k/v param.Although the cloud version of the API no longer uses/requires this param, customers running GHES could upgrade their version of
dependabot-corebut against an older version of the API which still requires/uses this param. So I continued to send the param, but as a placeholder string of"deprecated", so that nothing breaks.Again, this param is no longer used by the cloud's version of the API, so it will never see the
ecosystemplaceholder value.Related PR's:
record_ecosystem_versionsendpoint. #7517