Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes [weekly 2k] [experiment] [npm_and_yarn] expected content to change errors #11423

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fixes [weekly 2k] [experiment] [npm_and_yarn] expected content to change errors #11423

merged 1 commit into from
Jan 28, 2025

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 28, 2025 •
edited
Loading

What are you trying to accomplish?

Experiment: Adds experiment to fix "expected content to change error" when updating package.json with a dependency meant for package-lock.json

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 28, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/expected-change-in-package-json branch from 868b436 to daa205d Compare January 28, 2025 02:56
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 28, 2025 13:07
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 28, 2025 13:07
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/expected-change-in-package-json branch from daa205d to c39499e Compare January 28, 2025 13:45
@sachin-sandhu sachin-sandhu marked this pull request as draft January 28, 2025 13:45
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 28, 2025 13:56
randhircs
randhircs approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TMLG

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/expected-change-in-package-json branch from c39499e to bbc4f4d Compare January 28, 2025 15:44
@sachin-sandhu sachin-sandhu merged commit 064cf8a into main Jan 28, 2025
66 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/expected-change-in-package-json branch January 28, 2025 16:16
sachin-sandhu added a commit that referenced this pull request Jan 31, 2025
@sachin-sandhu
Adds changes for experiment to fix expected cotent to change error. (#…
d94db82 
…11423)
@rhyskoedijk rhyskoedijk mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhircs randhircs randhircs approved these changes

Assignees

@sachin-sandhu sachin-sandhu

Labels
L: javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachin-sandhu @randhircs