install .NET SDKs as specified by repo's global.json files
#11090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-install-dotnet-sdks
branch
3 times, most recently
from
e984586 to
95033a6
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-install-dotnet-sdks
branch
from
95033a6 to
75e779a
Compare
ryanbrandenburg
approved these changes
Dec 16, 2024
randhircs
force-pushed
the
dev/brettfo/nuget-install-dotnet-sdks
branch
from
75e779a to
4ebd9ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new behavior behind the experiment flag
nuget_install_dotnet_sdks. This experiment is not yet enabled anywhere.The NuGet updater currently has 2 installed .NET SDKs,
8.0.404and9.0.100.This PR crawls the directories specified in the job file to install the exact SDKs required by the target repo. It also adds a new helper method to run
dotnetcommands as a subprocess and before starting the process, it removes allMSBuild*environment variables. This is done because when adotnetprogram is running, including the updater tool, it sets some variables indicating where MSBuild came from, but we don't want that in case the user has aglobal.jsonfile; we instead wantdotnetto rediscover the correct values. This will prevent, e.g., a 9.x SDK from trying to load 7.x MSBuild binaries.