Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload releases as targz #8

Closed
ThatOneCalculator opened this issue Sep 15, 2022 · 3 comments · Fixed by #10
Closed

Upload releases as targz #8

ThatOneCalculator opened this issue Sep 15, 2022 · 3 comments · Fixed by #10

Comments

@ThatOneCalculator
Copy link

When uploading zips, the files loose their permissions/executability
@7coil
Copy link
Member

7coil commented Sep 15, 2022 •
edited
Loading

Sounds like a simple change to do... except currently GitHub Artifacts will .zip a .tar.gz (actions/upload-artifact#109)

Either:

  • We accept zipping up a .tar.gz
  • We have instructions on how to chmod +x

Might ask around first before resolving this.

@7coil
Copy link
Member

7coil commented Sep 15, 2022

Wait, releases?

I can change them...

7coil added a commit that referenced this issue Sep 15, 2022
@7coil
fix: #8 Upload .tar.gz copy of DECtalk for uploading to GitHub rele…
f3d0425 
…ases
@7coil 7coil linked a pull request Sep 15, 2022 that will close this issue
fix: #8 Upload .tar.gz copy of DECtalk for uploading to GitHub releases #10
Merged
7coil added a commit that referenced this issue Sep 15, 2022
@7coil
fix: #8 Tar whilst in root instead of src/
5029bb2
@7coil
Copy link
Member

7coil commented Sep 16, 2022

7zFM_hpGFj37DzQ

Looks like we have the execute bit now!

@7coil 7coil closed this as completed Sep 16, 2022
7coil added a commit that referenced this issue Sep 16, 2022
@7coil
Merge pull request #10 from dectalk/8-upload-targz-artifact
77de009 
fix: #8 Upload `.tar.gz` copy of DECtalk for uploading to GitHub releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #8 Upload .tar.gz copy of DECtalk for uploading to GitHub releases dectalk/dectalk
2 participants
@7coil @ThatOneCalculator