Skip to content
This repository was archived by the owner on Dec 28, 2024. It is now read-only.

Fix grpc/datastore tests #122

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Fix grpc/datastore tests #122

merged 2 commits into from
Oct 15, 2019

Conversation

jonasfj
Copy link
Contributor

@jonasfj jonasfj commented Sep 3, 2019

No description provided.

@jonasfj
Copy link
Contributor Author

jonasfj commented Sep 3, 2019

There is still a timeout, but at least this fixed most of the test cases :)

[appengine]$pub run test
00:35 +27: test/integration/grpc_datastore_test.dart: e2e_datastore empty_commit negative_empty_commit_xg
  Skip: Existing failure
01:12 +29 ~1 -1: test/integration/grpc_datastore_test.dart: e2e_datastore query query [E]
  TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
  package:test_api  Invoker._onRun.<fn>.<fn>.<fn>

01:40 +39 ~1 -1: Some tests failed.
[appengine]$

@jonasfj
Copy link
Contributor Author

jonasfj commented Sep 3, 2019

Fixed the last test by bumping the timeout...

[appengine]$pub run test
00:37 +27: test/integration/grpc_datastore_test.dart: e2e_datastore empty_commit negative_empty_commit_xg
  Skip: Existing failure
01:44 +40 ~1: All tests passed!
[appengine]$

@domesticmouse
Copy link
Contributor

QQ, do you think this will fix dart-lang/labs#167?

@jonasfj
Copy link
Contributor Author

jonasfj commented Oct 15, 2019

Doubtful, this only touches the test files :)

@jonasfj jonasfj merged commit 223db49 into dart-archive:master Oct 15, 2019
@jonasfj jonasfj deleted the fix-tests branch October 15, 2019 03:58
devoncarew pushed a commit to dart-lang/labs that referenced this pull request Oct 1, 2024
* Fix grpc/datastore tests

* Increase test timeout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants