Bugfix/hide change password for hub vault

[iammajid]

Fixes issue #360 where the "Change password" option is shown despite Hub not relying on passwords for key derivation.

[coderabbitai]

Walkthrough

The recent updates enhance the flexibility and functionality of the vault management system. A dynamic section arrangement in the vault detail view allows for better user interaction, while a new computed property in the VaultInfo class improves the retrieval of vault configuration types. These changes collectively streamline data handling and create a more adaptable user interface.

Changes

Files	Summary
Cryptomator/VaultDetail/...	Modified VaultDetailViewModel.swift to implement a dynamic array for vault detail sections, improving control flow and maintainability.
Cryptomator/VaultList/...	Added vaultConfigType computed property in VaultInfo.swift to determine vault configuration type from cached data.

Poem

In the vaults where secrets lie,
A rabbit hops, quite spry and spry.
With sections shifting, oh what fun!
A dance of data, just begun!
Configs change like clouds above,
Hooray for updates made with love! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 25d7d2f and 85bdb86.

Files selected for processing (2)

• Cryptomator/VaultDetail/VaultDetailViewModel.swift (1 hunks)
• Cryptomator/VaultList/VaultInfo.swift (1 hunks)

Additional comments not posted (2)

Cryptomator/VaultList/VaultInfo.swift (1)

61-69: LGTM! But verify the helper functions and error handling.

The code changes are approved.

However, ensure that the helper functions (VaultDBCache().getCachedVault, UnverifiedVaultConfig.init, and VaultConfigHelper.getType) and error handling are implemented correctly.

Cryptomator/VaultDetail/VaultDetailViewModel.swift (1)

88-101: LGTM! But verify the helper functions and conditions.

The code changes are approved.

However, ensure that the helper functions (vaultIsEligibleToMove, vaultInfo.vaultConfigType) and conditions are implemented correctly.

Verification successful

---

Verified the helper functions and conditions.

The helper functions vaultIsEligibleToMove and vaultConfigType are correctly implemented and align with their intended purposes. The code changes are approved.

• vaultIsEligibleToMove checks if the cloudProviderType is localFileSystem and if the vaultPath is not the root path.
• vaultConfigType retrieves the type from a cached vault configuration or returns .unknown if not found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the implementations of helper functions and conditions.

# Test: Search for the implementations of the helper functions. Expect: Correct implementations.
ast-grep --lang swift --pattern $'class VaultDetailViewModel {
  $$$
  private func vaultIsEligibleToMove() -> Bool {
    $$$
  }
  $$$
}'

ast-grep --lang swift --pattern $'class VaultInfo {
  $$$
  var vaultConfigType: VaultConfigType {
    $$$
  }
  $$$
}'

Length of output: 1293

---

Script:

#!/bin/bash
# Description: Verify the implementations of helper functions and conditions.

# Test: Search for the implementation of the vaultIsEligibleToMove method.
ast-grep --lang swift --pattern $'private func vaultIsEligibleToMove() -> Bool {
  $$$
}' 

# Test: Search for the implementation of the vaultConfigType property.
ast-grep --lang swift --pattern $'var vaultConfigType: VaultConfigType {
  $$$
}' 

Length of output: 1465

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 85bdb86 and 6c60058.

Files selected for processing (1)

• Cryptomator/VaultDetail/VaultDetailViewModel.swift (1 hunks)

Additional comments not posted (1)

Cryptomator/VaultDetail/VaultDetailViewModel.swift (1)

88-96: The sections array logic is correctly implemented.

The initialization and conditional logic for appending sections improve readability and maintainability. The changes align with the PR objectives by conditionally including the changeVaultPasswordSection only for masterkeyFile vaults.