Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Notification Service 'update' Toasts Use Incorrect Class Name #2997

Open
1 task done
phroggster opened this issue Feb 15, 2025 · 0 comments
Open
1 task done
Assignees
Labels
Bug A defect in the app Dev Approved The issue has been approved by a team member and can be worked on. Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release

Comments

@phroggster
Copy link
Collaborator

phroggster commented Feb 15, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Update notification alerts use a toastClass of "warn" when "warning" was likely intended.

ngToast/Bootstrap-css provide for several alert classes: ["success", 'info", "warning", "danger"], of which "warn" is not in this list. Additionally, "warn" does not appear anywhere else in the code base, excluding logger.warn and an (unused) Twitch warn event. As such, this was likely a mere misspelling. However, it's possible that this is in-fact not a bug, and is intended behavior.

ngToast docs (unversioned)
Bootstrap 3.4 docs

Expected Behavior

Toast that is properly browned, but not burned.

Steps To Reproduce

  1. Start the Firebot nightly or run from source in the v5 branch.
  2. Add and commit an "update" message to the metadata branch in notifications/notifications.json.
  3. Wait for the toast to cook.

Version

5.64-sources

What operating system are you using Firebot on?

Windows 10

Relevant log output

No response

Contact Details (Optional)

No response

@phroggster phroggster added the Bug A defect in the app label Feb 15, 2025
@github-project-automation github-project-automation bot moved this to Todo in Firebot Feb 15, 2025
phroggster added a commit to phroggster/Firebot that referenced this issue Feb 15, 2025
@phroggster phroggster added Dev Complete Ready For Review Issue has a PR opened and is undergoing dev review. labels Feb 15, 2025
@CaveMobster CaveMobster added the Dev Approved The issue has been approved by a team member and can be worked on. label Feb 15, 2025
CaveMobster pushed a commit that referenced this issue Feb 16, 2025
@CaveMobster CaveMobster added Release Pending Issue has been resolved and is waiting to be packaged as part of a release and removed Ready For Review Issue has a PR opened and is undergoing dev review. labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A defect in the app Dev Approved The issue has been approved by a team member and can be worked on. Dev Complete Release Pending Issue has been resolved and is waiting to be packaged as part of a release
Projects
Status: Todo
Development

No branches or pull requests

2 participants