-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clang as a common build tool #608
Conversation
I ran into a similar issue while trying to run
(from https://apt.llvm.org/) |
I also had issues with Clang 3.8 which is the packaged version for Ubuntu 16.04. If any help the images are available as jenoch/rust-cross and the Dockerfiles are in https://github.com/JEnoch/rust-cross-clang/. I only made images for ARMs and x86_64+musl so far. I'm not sure if/how what I did can be adapted as a PR in here for all Docker images. |
To get bindgen working, all I did was use this docker image:
Just libclang-3.9-dev is enough, no PPA necessary. |
I've changed the library to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, CI is broken
r=me when fixed
Remaining errors are due to a timeout also observed in #609 |
bors r+ |
Build succeeded: |
Closes #174
This PR adds clang as a common build tool.
The libclang will be used by bindgen so It's better to have clang on all platforms so I add to common.sh
This works for bindgen for the following targets with
ffmpeg-next
oflibavformat
,libavcodec
, andlibavutil
with my built ffmpeg binaries:x86_64-pc-windows-gnu
x86_64-unknown-linux-musl
I couldn't test
x86_64-unknown-linux-gnu
because of #455#455 error message. This will be happened without this PR (with the image from DockerHub)