Minor improvements to wording #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo in "QEMU bug sand"
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks. Will merge this once we sort out some unrelated issues in the build which will block this PR. |
reitermarkus
approved these changes
Aug 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2019
251: Support mounting on SELinux r=reitermarkus a=cyplo This should allow `cross` to work on both non-SELinux enabled systems and SELinux ones. I've tested on Fedora 29 for SELinux system. Fixes #112 that was originally reported from Fedora as well I believe. 271: Minor improvements to wording r=reitermarkus a=spl * Fix a typo in "QEMU bug sand" * Add a link for QEMU * Clarify and simplify various other things about the wording The diff looks worse than the changes are. I tried to keep to the 80-column width since it looked like the rest of the text was that way. GitHub's “rich diff” seems to help here. Co-authored-by: Cyryl Płotnicki <[email protected]> Co-authored-by: Sean Leather <[email protected]>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2019
271: Minor improvements to wording r=reitermarkus a=spl * Fix a typo in "QEMU bug sand" * Add a link for QEMU * Clarify and simplify various other things about the wording The diff looks worse than the changes are. I tried to keep to the 80-column width since it looked like the rest of the text was that way. GitHub's “rich diff” seems to help here. Co-authored-by: Sean Leather <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff looks worse than the changes are. I tried to keep to the 80-column width since it looked like the rest of the text was that way. GitHub's “rich diff” seems to help here.