Update docker-compose files #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actualize docker-compose files with actual binaries
updated CHANGELOG_DEV.md
vixentael
approved these changes
Nov 10, 2021
vixentael
reviewed
Nov 10, 2021
| @@ -73,7 +73,7 @@ ENV PATH="$PATH:/usr/local/lib/go/latest/bin" | |||
| ENV PATH_ACRA="/acra" | |||
| COPY ./ "${PATH_ACRA}/" | |||
| # Fetch all dependencies and build all binaries in acra | |||
| RUN cd "${PATH_ACRA}" && go install ./cmd/... | |||
| RUN cd "${PATH_ACRA}" && go install -tags netgo ./cmd/... | |||
There was a problem hiding this comment.
Need additional testing from @shadinua
There was a problem hiding this comment.
Tested with scratch and Debian-based images. Thanks!
|
I propose to leave this PR open until @shadinua confirms that all is okay with other cases of resolving and after that merge. To not merge not tested configurations. To not revert changes after that with new one PR) |
Lagovas
approved these changes
Nov 10, 2021
shadinua
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actualizing docker-compose files with new versions of binaries stored on Github registry. Updated docker/acra-build.dockerfile with ability to compile binary files with native Golang
netgoDNS resolver.Corresponding changes displayed in CHANGELOG_DEV.md.
with new changes