fix occasionally commented censor's query capture test #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like this test should be updated a bit 🤔 |
|
I've updated it according to last changes in logging logic. Now it's user responsibility to redact query before writing to log, so we should only check if all queries have been written successfully |
Lagovas
approved these changes
Jan 21, 2019
| expected := "{\"raw_query\":\"SELECT Student_ID FROM STUDENT;\",\"_blacklisted_by_web_config\":false}\n" + | ||
| "{\"raw_query\":\"SELECT * FROM STUDENT;\",\"_blacklisted_by_web_config\":false}\n" + | ||
| "{\"raw_query\":\"SELECT * FROM X;\",\"_blacklisted_by_web_config\":false}\n" + | ||
| "{\"raw_query\":\"SELECT * FROM Y;\",\"_blacklisted_by_web_config\":false}\n" |
There was a problem hiding this comment.
we can drop it because it repeat previous or change "Y" -> "X" to test duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging censor's logging logic I occasionally commented this test. Now its time to restore it. Sorry, my fault