Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DB versions in docker demos #278

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Update DB versions in docker demos #278

merged 2 commits into from
Nov 6, 2018

Conversation

shadinua
Copy link
Contributor

@shadinua shadinua commented Nov 6, 2018

  • PostgreSQL 9.6 -> 11
  • MySQL 5.7 -> MariaDB 10.3

@shadinua
Update DB versions in docker demos
d0d350b 
* PostgreSQL 9.6 -> 11
* MySQL 5.7 -> MariaDB 10.3
@shadinua shadinua self-assigned this Nov 6, 2018
@shadinua shadinua requested review from vixentael and Lagovas November 6, 2018 14:38
@vixentael
Copy link
Collaborator

yey, MariaDB in da house!

Lagovas
Lagovas reviewed Nov 6, 2018
View reviewed changes
examples/python/example_with_zone.py Outdated
@@ -141,14 +143,14 @@ def write_data(data, connection):
metadata.create_all(engine)

if args.print:
print_data(args.zone_id, connection)
print_data(args.zone_id, connection, driver)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about place print('DB driver: {}'.format(driver)) before if args.print else statement and don't pass it to 2 functions with extra parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks :-)

examples/python/example_without_zone.py Outdated
@@ -109,6 +111,6 @@ def write_data(data, connection):
connection = engine.connect()

if args.print:
print_data(connection)
print_data(connection, driver)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@vixentael vixentael merged commit 66253ca into master Nov 6, 2018
@vixentael vixentael deleted the shadinua/T843_update_demo branch November 6, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@Lagovas Lagovas Lagovas approved these changes

Assignees

@shadinua shadinua

Labels
examples infrastructure mysql postgresql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadinua @vixentael @Lagovas