Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to generating keys and placing them into directory structure #181

Merged
merged 2 commits into from
May 28, 2018

Conversation

shadinua
Copy link
Contributor

  • added script to generating keys and placing them into appropriate directory structure
  • added gen_keys target in Makefile to run generate-keys.sh script with default arguments

@vixentael
Copy link
Collaborator

Thank you, I think that this script is very useful for users.

However, I have doubts about gen_keys name. The Acra component name is acra-keymaker. Not sure if gen_keys is a best name, but I don't have any other suggestions really :/

By the way, can you please rename SERVICE_NAME from acra-genkeys into acra-keymaker?
https://github.com/cossacklabs/acra/blob/master/cmd/acra-keymaker/acra-keymaker.go#L29

I understand that it's outside of scope of this PR, I think we just forgot to fix the service name. But I strongly believe it will be better to add it to this PR 🙃

@shadinua
Copy link
Contributor Author

Thank you for reply!

  • I've renamed Makefile's target to keys, so the command will sound like make keys.
  • I've fixed SERVICE_NAME.

@shadinua shadinua merged commit 29d1940 into master May 28, 2018
@shadinua shadinua deleted the T480_script_keymaker branch May 28, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants