add auth mode param #171
Merged
add auth mode param #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
reviewed
May 4, 2018
| def get_connector_tls_params(self): | ||
| return [ | ||
| '--tls', | ||
| '--tls_sni=acraserver', |
There was a problem hiding this comment.
we should not forget to rename this to acra-server in rename branch
There was a problem hiding this comment.
it doesn't matter here. at first - it is tests. and it's depends on values in certificate that used in tests
There was a problem hiding this comment.
oh right, it's a value inside certificate 🙈
vixentael
approved these changes
May 4, 2018
shadinua
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add settings that change tls authentication mode. in AcraConnector it set how it will authenticate AcraServer in tls connection, on AcraServer side it setup how it will authenticate database in tls connection
plus updated tls configuration to provide other less strict authentication methods (not authenticate client from server, require any certificate, require and check) as it implemented in other places (for examples in dbs)