mysql tls support #140
Merged
mysql tls support #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
reviewed
Apr 2, 2018
cmd/acraserver/acraserver.go
Outdated
| if err != nil { | ||
| log.WithError(err).WithField(logging.FieldKeyEventCode, logging.EventCodeErrorTransportConfiguration). | ||
| Errorln("Configuration error: can't get config for TLS") | ||
| os.Exit(1) | ||
| } | ||
| // need for testing with mysql docker container that always generate new certificates | ||
| if Test == TEST_MODE { |
There was a problem hiding this comment.
Won't it be better to rename Test into SkipVerifyingCertificated?
There was a problem hiding this comment.
thought to name it more common to use in future tests if need
There was a problem hiding this comment.
what about 'IsRunningTest'? 'TestOnly'?
There was a problem hiding this comment.
by the way, why do you check
if Test == TEST_MODE
instead of if Test == True?
There was a problem hiding this comment.
on compile time we can change only string values
There was a problem hiding this comment.
will rename to TestOnly
vixentael
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.