-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64 #1070
Arm64 #1070
Conversation
This PR is stale because it has been open 45 days with no activity. |
This PR is stale because it has been open 45 days with no activity. |
I built/tested this version, there's an error in the version check logic preventing the install of the latest ARM64 (22.5.1) version: As currently written, for the latest version (22.5.1), it passes the main version check, but then fails the minor version check since the value of minor is 5 which is lower than 9.
|
This PR is stale because it has been open 45 days with no activity. |
Update - I'm working with Microsoft to get a new code signing certificate. Once that is done, I'll start merging PRs (including this one). |
This PR is stale because it has been open 45 days with no activity. |
Hi, |
Only the 64-bit binaries of nvm exist as of the latest release (https://github.com/coreybutler/nvm-windows/releases/tag/1.2.1) 🤔 |
how should this work? so should there be a setup.exe of nvm that is for aarch64 that downloads then the aarch64 of nodejs? or should the x86 variant of nvm do that depending on what it arch it sees? |
Yes, originally it uses an arch for which it was compiled. Since there are no provided binaries for every platform, you may need to use the arch option to install for arm (e.g., I've made a PR that updates arch detection, but I'm not sure if it will work in all cases. I'll look for a better way to detect arm arch. |
Support windows-arm64.