Add .coafile and Travis lint job #59
+1,731
−820
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| [all] | ||
| ignore = node_modules/**, dist/**, .git/** | ||
| use_spaces = true | ||
|
|
||
| [all.SpaceConsistencyBear] | ||
| files = **.js, **.json, **.yml, **.yaml, **.md | ||
| bears = SpaceConsistencyBear | ||
| # gantt-chart.js contains mixture of tabs and spaces | ||
| ignore += src/gantt-chart.js | ||
|
|
||
| [all.json] | ||
| bears = JSONFormatBear | ||
| files = **.json | ||
| indent_size = 2 | ||
|
|
||
| [all.js] | ||
| bears = ESLintBear | ||
| eslint_config = .eslintrc | ||
| files = **.js | ||
| ignore += src/gantt-chart.js | ||
|
|
||
| [all.markdown] | ||
| bears = MarkdownBear | ||
| files = **.md | ||
|
|
||
| [all.yaml] | ||
| bears = YAMLLintBear | ||
| files = **.yml, **.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,25 +5,50 @@ cache: | |
| directories: | ||
| - "node_modules" | ||
|
|
||
| .disable_global: &disable_global | ||
| node_js: false | ||
| cache: false | ||
| before_install: false | ||
| install: false | ||
| before_script: false | ||
| script: false | ||
| after_success: false | ||
| before_deploy: false | ||
| deploy: false | ||
|
|
||
| # env forces jobs to be created from the top level settings | ||
| env: | ||
| jobs: | ||
| include: | ||
| - <<: *disable_global | ||
| stage: moban | ||
| language: python | ||
| python: 3.6 | ||
| cache: pip | ||
| install: pip install moban | ||
| script: .ci/check_moban.sh | ||
|
|
||
| - <<: *disable_global | ||
| stage: lint | ||
| language: python | ||
| python: 3.6 | ||
| cache: | ||
| pip: true | ||
| directories: | ||
| - node_modules | ||
| before_install: | ||
| - export PATH=$PATH:./node_modules/.bin | ||
| - export NODE_PATH=$NODE_PATH:./node_modules | ||
| install: | ||
| - pip install coala-bears | ||
| - npm install | ||
| script: coala --non-interactive -V | ||
|
|
||
| # Needed for Firefox | ||
| before_script: | ||
| - export DISPLAY=:99.0 | ||
| - sh -e /etc/init.d/xvfb start | ||
| - sleep 3 # give xvfb some time to start | ||
|
|
||
| script: | ||
| - npm run test | ||
|
|
@@ -42,5 +67,5 @@ deploy: | |
| provider: pages | ||
| skip_cleanup: true | ||
| github_token: $GITHUB_TOKEN | ||
| "on": | ||
|
There was a problem hiding this comment. I vaguely remember doing something like this in the past, but my quick searches couldn't come up with anything. What's the story behind this? There was a problem hiding this comment. it is from the yaml lint bear. There was a problem hiding this comment. yup @andrewda did. coala/gci-leaders@dff8ba5 There was a problem hiding this comment. Haha, I knew that was familiar 😂 |
||
| branch: master | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this is annoying ... as the rule is generally ok, but there are a bunch of exceptions which probably need to be added to get it working. (help ...?)
An alternative is to not ugprade eslint to 4.19. I chose that version because it is the same as being used on git-task-list, and IMO we should aim at having the same in our JS repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Airbnb style actually uses 4.9 as peer dependency. I really want to downgrade to that matching version :( too. Waiting for @blazeu .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was using 4.19 as i though, later is better. (it was before adding airbnbstyleguide)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it doesnt @bekicot.
It uses
eslint: '^4.9.0', which in case you didnt know means any version of 4, after that.To check what a JS semvar spec means, https://semver.npmjs.com/ is very helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.9 seems to work fine and no additional overhead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it would work with 4.19 with no dependency error. But it add additional overhead.