Add Content-Length: 0 request header for empty POST etc.
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for when this library will automatically add an outgoing `Content-Length` request header and that this header should only be passed manually for request streaming. Additionally, we now make sure to include a `Content-Length: 0` request header if the request body is known to be empty and the request method usually expects a request body (only applies to `POST`, `PUT` and `PATCH`). While not strictly required by the newer RFC 7230, this does improve compatibility with some HTTP servers which seem to follow the older RFC 2616 semantics.
|
@CharlotteDunois Thank you for confirming, I believe this to be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for when this library will automatically add an
outgoing
Content-Lengthrequest header and that this header shouldonly be passed manually for request streaming.
Additionally, we now make sure to include a
Content-Length: 0requestheader if the request body is known to be empty and the request method
usually expects a request body (only applies to
POST,PUTandPATCH). While not strictly required by the newer RFC 7230, this doesimprove compatibility with some HTTP servers which seem to follow the
older RFC 2616 semantics.
Resolves / closes #117