Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Default config lists maincloud, not testnet #2237

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Feb 10, 2025

Description of Changes

Replaced testnet with maincloud in the default config file.

I did not replace it in any of our tests, since those test config files don't actually need to be synced with our real config files. I can replace there too if that's preferred.

API and ABI breaking changes

Not breaking.

Expected complexity level and risk

1

Testing

  • Remove config file, run a CLI command, see that maincloud is in the config file now
$ rm ~/.config/spacetime/cli.toml

$ cargo run -p spacetimedb-cli -- server add foo --url https://foo.spacetimedb.com --no-fingerprint
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s
     Running `target/debug/spacetimedb-cli server add foo --url 'https://foo.spacetimedb.com' --no-fingerprint`
Saving config to /home/lead/.config/spacetime/cli.toml.
WARNING: This command is UNSTABLE and subject to breaking changes.

Host: foo.spacetimedb.com
Protocol: https
Saving config to /home/lead/.config/spacetime/cli.toml.

$ cat ~/.config/spacetime/cli.toml
default_server = "local"

[[server_configs]]
nickname = "local"
host = "127.0.0.1:3000"
protocol = "http"

[[server_configs]]
nickname = "maincloud"
host = "maincloud.spacetimedb.com"
protocol = "https"

[[server_configs]]
nickname = "foo"
host = "foo.spacetimedb.com"
protocol = "https"

@bfops bfops linked an issue Feb 10, 2025 that may be closed by this pull request
@bfops bfops marked this pull request as ready for review February 10, 2025 19:49
@bfops bfops requested a review from cloutiertyler as a code owner February 10, 2025 19:49
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. We just want to merge at a strategic time so as to not mess up the BitCraft team as much as possible.

@bfops bfops enabled auto-merge February 11, 2025 02:46
@bfops bfops added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit 6fc5ce4 Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maincloud as a default server to config file
2 participants