commitlog: Make memory segment behave like O_APPEND
#2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To mirror the file-backed `Repo` implementation. `O_APPEND` may or may not have been the right choice, but tests using the in-memory backend should expect the same behavior as the file backend.
kim
force-pushed
the
kim/commitlog/mem-o-append
branch
from
1860e4a to
ca573b6
Compare
Shubham8287
approved these changes
Dec 20, 2024
mamcx
pushed a commit
that referenced
this pull request
Dec 26, 2024
mamcx
pushed a commit
that referenced
this pull request
Jan 6, 2025
mamcx
pushed a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mirror the file-backed
Repoimplementation.O_APPENDmay or may not have been the right choice, but tests using the in-memory backend should expect the same behavior as the file backend.Expected complexity level and risk
1
Testing
The existing test suite covers the change.
Two test cases have been adjusted.